Make mne.sys_info() work with powershell 7+ #13593
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmvanvliet
requested review from
agramfort,
dengemann,
drammock and
larsoner
as code owners
drammock
approved these changes
Jan 15, 2026
Member
drammock
left a comment
drammock
left a comment
There was a problem hiding this comment.
diff looks good. To verify it works, I checked and couldn't find a CI that uses windows and was previously showing total memory of 0 and is now giving a real number; CIs all seem to be windows 10 / windows server 10. So we'll have to take your word for it @wmvanvliet
Contributor
Author
|
loads of CI failures, that doesn't look good 🤔 |
Member
most are a numpy deprecation, I've just opened #13594 to address |
Member
|
Nice, thanks @wmvanvliet ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mne.sys_infouses powershell in Windows to query memory and CPU.The newer (version 7+) powershell executable is called
pwshinstead ofpowershell. My Windows11 system no longer seems to have the old one. This PR adds compatibility so it works for all versions.